Re: [GIT PULL] locking fixes

[Ingo Molnar]

* Ingo Molnar <mingo@xxxxxxxxxx> wrote:

> ( I've attached the build log that I saw before sending you 
>   the pull request. )
> 
> The kbuild test robot which tests for warnings didn't 
> report one to me either. I tested a few other configs as 
> well:
> 
>   x86 defconfig (PARAVIRT=n):        0 warnings
>   'make kvmconfig' (PARAVIRT=y):     0 warnings
>   x86 bootable config (attached):    0 warnings

Oh, crap, I just triggered the warnings with:

 x86 defconfig + 'make kvmconfig' + CONFIG_PARAVIRT_SPINLOCKS=y.
 
My bad, mea culpa ...

I just tested your patch.diff and it fixed the warnings:

  Tested-by: Ingo Molnar <mingo@xxxxxxxxxx>

Extra sad: I _did_ build and boot test paravirt spinlocks 
as well, but only within a test environment that does not 
show warnings (in general there's too many of them, even 
defconfig is rarely warnings free, although it is with the 
very latest kernel) and my burn-in test before the pull 
request didn't have paravirt spinlocks turned on.

But you do allmodconfig tests and look at warnings so there 
it probably showed up straight away?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/