Re: [GIT PULL] time/ntp fix

From: Ingo Molnar
Date: Sat Feb 21 2015 - 00:49:58 EST

* John Stultz <john.stultz@xxxxxxxxxx> wrote:

> On Fri, Feb 20, 2015 at 2:26 PM, Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> > On Fri, Feb 20, 2015 at 5:44 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> >>
> >> John Stultz (1):
> >> ntp: Fixup adjtimex freq validation on 32-bit systems
> >
> > This is confusing. 32-bit?
> Right, so the check that was added in a previous commit
> is really only a concern for 64bit systems, but was
> applied to both 32 and 64bit systems, which results in
> breaking 32bit systems.
> Thus the "fix" here is to make the check only apply to
> 64bit systems.

Yeah, perhaps a better commit title would have been to

time/ntp: Fix adjtimex freq validation code build warning on 32-bit systems

To make it clear that the problem fixed is a 32-bit
warning, and that the fix for that is to only check on
64-bit systems.

I agreed with your BITS_PER_LONG check when I reviewed your
patch, people usually do an ugly #ifdef, I think this
in line check form is nicer.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at