Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

From: Pali RohÃr
Date: Sun Feb 22 2015 - 06:04:51 EST

On Thursday 19 February 2015 11:58:29 Gabriele Mazzotta wrote:
> This patch adds the support for the configuration of the
> keyboard backlight on supported Dell laptops.
> With this patch it is possible to set:
> * keyboard backlight level
> * timeout after which the backlight will be automatically
> turned off * input activity triggers (keyboard, touchpad,
> mouse) that enable the backlight * ambient light settings
> The settings are exposed via
> /sys/class/leds/dell::kbd_backlight/
> The code is based on the newly released documentation by Dell
> in the libsmbios project.
> Signed-off-by: Pali RohÃr <pali.rohar@xxxxxxxxx>
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@xxxxxxxxx>
> Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> .../ABI/testing/sysfs-platform-dell-laptop | 69 ++
> drivers/platform/x86/dell-laptop.c | 1089
> +++++++++++++++++++- 2 files changed, 1152 insertions(+), 6
> deletions(-)
> create mode 100644
> Documentation/ABI/testing/sysfs-platform-dell-laptop

This patch is same as combination of previous, just contains all
changes in single patch file. Difference between v3.19-rc5 and
current version is just als code was moved to separate functions
and als backlight can be enabled via new sysfs attribute (like in
second patch which was sent).

I tested this patch on top of linus tree (commit 79513d0) and
keyboard backlight works fine.

Darren, what do you think, can be this patch which brings
keyboard backlight support finally moved to mainline kernel?

Pali RohÃr

Attachment: signature.asc
Description: This is a digitally signed message part.