Re: [PATCH v2 3/4] scsi: ufs: add trace events and dump prints for debug

From: Gilad Broner
Date: Sun Feb 22 2015 - 09:58:51 EST


>> struct ufs_stats {
>> +#ifdef CONFIG_DEBUG_FS
>> bool enabled;
>> u64 **tag_stats;
>> int q_depth;
>> int err_stats[UFS_ERR_MAX];
>> +#endif
>
> Can any of the tracepoint code be called that references these when
> CONFIG_DEBUG_FS is not set? Because soon (possibly even this merge
> window), tracing will no longer depend on DEBUG_FS, because it will
> have its own filesystem.

Thanks for the update about this dependency.
None of these are used for the tracepoints, so I don't expect any problems.

Gilad.

--
Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/