Re: [PATCH v2 2/4] scsi: ufs: add debugfs for ufs

[Gilad Broner]

> UFSDBG_REMOVE_DEBUGFS() is not called in the driver unloading path.
> So ufs debugfs directory is not removed when unloading driver.  It
> should be called in ufshcd_remove().
>
> BTW, do we really need UFSDBG_ADD_DEBUGFS() and UFSDBG_REMOVE_DEBUGFS()
> macros?
> We can use static inline functions in ufs-debugfs.h when !CONFIG_DEBUG_FS.
>
> #ifdef CONFIG_DEBUG_FS
> void ufsdbg_add_debugfs(struct ufs_hba *hba);
>
> void ufsdbg_remove_debugfs(struct ufs_hba *hba);
> #else
> static inline void ufsdbg_add_debugfs(struct ufs_hba *hba)
> {
> }
>
> static inline void ufsdbg_remove_debugfs(struct ufs_hba *hba)
> {
> }
> #endif
>

Thanks, I will fix the above two points and upload another patch.

Gilad.

-- 
Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/