Re: [PATCH 7/7] thinkpad_acpi: use DEVICE_ATTR_* macros

From: Henrique de Moraes Holschuh
Date: Mon Feb 23 2015 - 05:25:31 EST

On Fri, Feb 20, 2015, at 11:44, Bastien Nocera wrote:
> Use the DEVICE_ATTR_RW macro to reduce boiler plate

So far, so good, but you also used the DEVICE_ATTR_RO macro...

> and move the attribute declaration to get rid of function signatures.

I didn't see any "move the attribute declaration" done in this patch.

Other than that, looks good.

"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at