Re: [PATCH 5/6] input: Add keycodes used by Lenovo Carbon X1 2014

From: Henrique de Moraes Holschuh
Date: Mon Feb 23 2015 - 05:49:56 EST

On Mon, Feb 23, 2015, at 07:15, Bastien Nocera wrote:
> On Wed, 2015-02-18 at 21:34 -0200, Henrique de Moraes Holschuh wrote:
> > On Wed, 18 Feb 2015, Bastien Nocera wrote:
> > > Signed-off-by: Bastien Nocera <hadess@xxxxxxxxxx>
> >
> > This one requires an ACK from the input maintainers, or no go...
> Any comments about the other patches?

The series looks mostly good, but the new keymap and attributes need to
in the driver documentation (Documentation/laptops/thinkpad-acpi.txt),
and some
of the commit decriptions could use an update.

You could opt to change some of those keypresses dinamically into
ACPI events, by setting the keymap entry to KEY_RESERVED. The driver
issue HKEY events in that case. That will be an viable alternative for
some of the new

The beauty of it is that keymaps are configurable in run-time, so
userspace can
just set any key entries it wants to change to something else, and ACPI
events will be
suppressed if the entry is not set to KEY_RESERVED anymore.

We need to be careful with tpacpi_input_send_key_masked(). If any of the
could call it from the adaptative keyboard handling code, it needs to be
updated (just
assume anything above 32 is enabled, as the firmware does not have an
event mask
for the new keycodes).

"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at