Re: [PATCH 2/3] resource: Add new flag IORESOURCE_WARN (64bit)

From: Andy Lutomirski
Date: Mon Feb 23 2015 - 10:47:14 EST


On Mon, Feb 23, 2015 at 4:43 AM, Boaz Harrosh <boaz@xxxxxxxxxxxxx> wrote:
>
> Resource providers set this flag if they want
> that request_region_XXX will print a warning in dmesg
> if this particular resource is locked by a driver.
>
> Thous acting as a Protocol Police about experimental
> devices that did not pass a comity approval.
>
> The warn print looks like this:
> [Feb22 19:59] resource: request unknown region [mem 0x100000000-0x1ffffffff] unkown-12
> Where the unkown-12 is taken from the res->name
>
> The Only user of this flag is x86/kernel/e820.c that
> wants to WARN about UNKNOWN memory types.
>
> NOTE: This patch looks very simple, a bit flag
> communicates between a resource provider ie e820.c
> that a warning should be printed, and resource.c
> prints such a message, when the resource is locked
> for use.

I'm not really convinced this is necessary. If you somehow manage to
reserve a physical address corresponding to an nvdimm, you probably
know what you're doing. After all, no in-tree driver will do this by
default.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/