Re: [PATCH v3 3/3] Linn Ethernet packet sniffer driver

[David Miller]

From: Stathis Voukelatos <stathis.voukelatos@xxxxxxxxxx>
Date: Mon, 23 Feb 2015 14:26:22 +0000

> Driver for the Ethernet Mii packet sniffer H/W module found in
> the IMG Pistachio SoC.
> 
> Signed-off-by: Stathis Voukelatos <stathis.voukelatos@xxxxxxxxxx>

You really have to explain what this thing does, how it is used,
what APIs are made use of to maniulate this device, etc.

Nobody knows what the packet sniffer module by your company is.

I also anticipate that once you describe adequately how this thing
behaves I won't like it, and I'll prefer that you integrate support
for your device using an exising facility such as AF_PACKET,
extending it if need be.

I am very far away from applying this series at this point, it needs
a lot more work and explanations.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/