Re: [PATCH v5 1/3] lib: find_*_bit reimplementation

[Rasmus Villemoes]

On Sun, Feb 22 2015, Yury Norov <yury.norov@xxxxxxxxx> wrote:

> New implementations takes less space in source file (see diffstat)
> and in object. For me it's 710 vs 453 bytes of text.
> It also shows better performance.
>
> find_last_bit description fixed due to obvious typo.
>

Hm, sorry, I should probably have reminded you to include linux/bitmap.h:

lib/find_last_bit.c: In function âfind_last_bitâ:
lib/find_last_bit.c:25:3: error: implicit declaration of function âBITMAP_LAST_WORD_MASKâ [-Werror=implicit-function-declaration]
lib/find_next_bit.c: In function â_find_next_bitâ:
lib/find_next_bit.c:37:2: error: implicit declaration of function âBITMAP_FIRST_WORD_MASKâ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
cc1: some warnings being treated as errors

With that fixed:

Reviewed-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>

That also applies to 2/3 and 3/3.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/