Re: [PATCH 2/3] media: omap3isp: ispvideo: drop driver specific isp_video_fh

From: Laurent Pinchart
Date: Mon Feb 23 2015 - 19:34:34 EST

Hi Prabhakar,

Thank you for the patch.

On Monday 23 February 2015 20:19:32 Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx>
> this patch drops driver specific isp_video_fh, as this
> can be handled by core.

I'm afraid it's not that simple.

The omap3isp driver stores video queues per file handle for a reason. This was
design to permit creating a high-resolution still image capture queue and
prepare buffers ahead of time, to avoid the large delay due to cache
management as prepare time when taking the snapshot.

Now this use case has been partially solved by VIDIOC_CREATE_BUFS, but we're
still missing a VIDIOC_DESTROY_BUFS to make it work completely. That needs to
be solved first.

> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
> ---
> drivers/media/platform/omap3isp/ispvideo.c | 128 ++++++++++---------------
> drivers/media/platform/omap3isp/ispvideo.h | 13 +--
> 2 files changed, 49 insertions(+), 92 deletions(-)


Laurent Pinchart

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at