Re: [PATCH 1/8] x86, kaslr: get kaslr_enabled back correctly
From: Ingo Molnar
Date: Sun Mar 01 2015 - 10:24:06 EST
(Cc:-ed Jiri and Kees as well.)
* Borislav Petkov <bp@xxxxxxx> wrote:
> On Sat, Feb 28, 2015 at 06:40:39PM -0800, Yinghai Lu wrote:
> >
> > oh, no. the offending commit already got into linus tree.
>
> We're working on it, follow this thread:
>
> http://lkml.kernel.org/r/1424929021.10337.24.camel@xxxxxxxxx
I think that's a different bug.
parse_kaslr_setup() is simply bogus, it does:
kaslr_enabled = (bool)(pa_data + sizeof(struct setup_data));
which makes no sense whatsoever: it randomly enables (or disables,
depending on the physical address of the setup page) KASLR when it
meets a SETUP_KASLR record.
So I'm inclined to apply Yinghai's fix, with a better changelog that
explains what happened ...
Agreed?
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/