Re: [PATCH v2] staging: lustre: fld_request.c: Remove else after return.
From: Greg KH
Date: Sun Mar 01 2015 - 20:31:06 EST
On Sat, Feb 28, 2015 at 01:37:23PM -0300, Alberto Pires de Oliveira Neto wrote:
> This patch fixes checkpatch.pl warning.
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@xxxxxxxxx>
> ---
> drivers/staging/lustre/lustre/fld/fld_request.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/fld/fld_request.c b/drivers/staging/lustre/lustre/fld/fld_request.c
> index b8d17e1..0b00301 100644
> --- a/drivers/staging/lustre/lustre/fld/fld_request.c
> +++ b/drivers/staging/lustre/lustre/fld/fld_request.c
> @@ -217,10 +217,9 @@ int fld_client_add_target(struct lu_client_fld *fld,
> CERROR("%s: Attempt to add target %s (idx %llu) on fly - skip it\n",
> fld->lcf_name, name, tar->ft_idx);
> return 0;
> - } else {
> - CDEBUG(D_INFO, "%s: Adding target %s (idx %llu)\n",
> - fld->lcf_name, name, tar->ft_idx);
> - }
> + }
> + CDEBUG(D_INFO, "%s: Adding target %s (idx %llu)\n",
> + fld->lcf_name, name, tar->ft_idx);
>
> OBD_ALLOC_PTR(target);
> if (target == NULL)
Never add new checkpatch errors when trying to fix checkpatch errors, as
you will never end up removing them...
Please fix and resend.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/