Re: [STLinux Kernel] [PATCH v3 5/8] watchdog: st_wdt: Add new driver for ST's LPC Watchdog

[Peter Griffin]

Hi Lee,

On Mon, 23 Feb 2015, Peter Griffin wrote:

> Hi Lee,

I noticed you sent another version, but I didn't see a reply on this point below.

As your now doing a re-spin for Pauls comments, I thought I would send a reminder
just in case you hadn't seen it.

regards,

Peter.

> 
> <snip>
> 
> > +#ifdef CONFIG_PM_SLEEP
> > +static int st_wdog_suspend(struct device *dev)
> > +{
> > +	struct st_wdog *st_wdog = watchdog_get_drvdata(&st_wdog_dev);
> > +
> > +	if (watchdog_active(&st_wdog_dev))
> > +		st_wdog_stop(&st_wdog_dev);
> > +
> > +	st_wdog_setup(st_wdog, false);
> 
> I was expecting the suspend / resume callbacks would be disabling / enabling
> the IP clock.
> 
> Is there a reason why it doesn't?
> 
> From looking at the code by this point the watchdog has already been disabled so gating
> the IP seems reasonable.
> 
> regards,
> 
> Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/