Re: [PATCH 2/2] w1: masters: omap_hdq: Add support for 1-wire mode

From: R, Vignesh
Date: Mon Mar 02 2015 - 02:59:07 EST



Hi,

On 2/27/2015 4:04 PM, Arnd Bergmann wrote:
> On Friday 27 February 2015 16:01:03 Vignesh R wrote:
>> On Friday 27 February 2015 03:25 PM, Arnd Bergmann wrote:
>>> On Friday 27 February 2015 14:54:17 Vignesh R wrote:
>>>> +- compatible : should be "ti,omap3-1w" or "ti,am43xx-hdq"
>>>>
>>>
>>> Do not use wildcards in the compatible string, use real part numbers
>>> if you don't know the actual name of the device.
>>
>>
>> The DT node for hdq on AM437x is already present in mainline
>> (commit: 741cac5f00beb) and it declares compatibility as
>> "ti,am43xx-hdq". Hence, I cannot change into anything different.
>>
>
> No, there is no driver using this device, and the binding was
> not documented, so there is no problem in changing it: nobody
> will notice a regression when it was never working before

Ok... I will change it to "ti,am4372-hdq"

Regards
Vignesh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/