Re: [PATCH] ext4: fix transposition typo in format string

[Rasmus Villemoes]

Ping... (maybe I should have used a more dramatic subject - I do think
this is a real bug, but if not, I'd still like to get an explicit NAK.)

On Fri, Feb 20 2015, Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> wrote:

> According to C99, %*.s means the same as %*.0s, in other words, print
> as many spaces as the field width argument says and effectively ignore
> the string argument. That is certainly not what was meant here. The
> kernel's printf implementation, however, treats it as if the . was not
> there, i.e. as %*s. I don't know if de->name is nul-terminated or not,
> but in any case I'm guessing the intention was to use de->name_len as
> precision instead of field width.
>
> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
> ---
> If de->name is not guaranteed to be nul-terminated, I suppose this is
> even -stable material.
>
>  fs/ext4/inline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
> index 4b143febf21f..8b64d715e476 100644
> --- a/fs/ext4/inline.c
> +++ b/fs/ext4/inline.c
> @@ -972,7 +972,7 @@ void ext4_show_inline_dir(struct inode *dir, struct buffer_head *bh,
>  	offset = 0;
>  	while ((void *)de < dlimit) {
>  		de_len = ext4_rec_len_from_disk(de->rec_len, inline_size);
> -		trace_printk("de: off %u rlen %u name %*.s nlen %u ino %u\n",
> +		trace_printk("de: off %u rlen %u name %.*s nlen %u ino %u\n",
>  			     offset, de_len, de->name_len, de->name,
>  			     de->name_len, le32_to_cpu(de->inode));
>  		if (ext4_check_dir_entry(dir, NULL, de, bh,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/