Re: 3.19: device name associates with IRQ's for ahci controllers operating with a single IRQ changed from "ahci?" to "<BDF>"
From: Tejun Heo
Date: Mon Mar 02 2015 - 14:10:58 EST
On Mon, Mar 02, 2015 at 06:58:10PM +0000, Alexander Gordeev wrote:
> On Mon, Mar 02, 2015 at 12:21:08PM -0500, Tejun Heo wrote:
> > Hello,
> > On Mon, Feb 16, 2015 at 05:28:42PM +0000, Alexander Gordeev wrote:
> > > The problem dates back to commit 4f37b50 ("libata: Use dev_name() for
> > > request_irq() to distinguish devices"). If the commit is considered valid
> > > then <BDF> still might be legitimate as well. Not sure what is the best
> > > approach here.
> > What does <BDF> indicate? Does it successfully identify the device in
> > question?
> I suppose, PCI bus-device-function.
> Yes, it does.
Hmmm... it does stand out like a sore thumb and we probably should use
a more descriptive identifier including the driver name. 4f37b50
("libata: Use dev_name() was fine for the specific platform device as
the device identifier included ide but not generally. :(
How about driver name followed by device ID?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/