Re: [PATCH] Staging: fbtft: fb_pcd8544: Fixed coding style errors and warnings

[Dan Carpenter]

On Tue, Mar 03, 2015 at 03:36:17AM +0000, Cláudio Maia wrote:
>     The following errors were fixed:
> 
>     ERROR: code indent should use tabs where possible
>     WARNING: line over 80 characters
> 
>     Signed-off-by: Cláudio Maia <crrm@xxxxxxxxxxx>

Don't indent this.

> @@ -52,60 +52,63 @@ static int init_display(struct fbtft_par *par)
>  	par->fbtftops.reset(par);
>  
>  	/* Function set */
> -	write_reg(par, 0x21); /* 5:1  1
> -	                         2:0  PD - Powerdown control: chip is active
> -							 1:0  V  - Entry mode: horizontal addressing
> -							 0:1  H  - Extended instruction set control: extended
> -						  */
> +	write_reg(par, 0x21); /*
> +			5:1  1
> +			2:0  PD - Powerdown control: chip is active
> +			1:0  V  - Entry mode: horizontal addressing
> +			0:1  H  - Extended instruction set control: extended
> +			*/

This looks kind of weird and this is not kernel style for commenting.
Read Documentation/CodingStyle.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/