Re: [PATCH net-next 10/14] bluetooth: Use eth_<foo>_addr instead of memset

From: Marcel Holtmann
Date: Tue Mar 03 2015 - 02:03:39 EST


Hi Joe,

> Use the built-in function instead of memset.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> net/bluetooth/bnep/netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/bnep/netdev.c b/net/bluetooth/bnep/netdev.c
> index 4b488ec..6ceb5d3 100644
> --- a/net/bluetooth/bnep/netdev.c
> +++ b/net/bluetooth/bnep/netdev.c
> @@ -218,7 +218,7 @@ static const struct net_device_ops bnep_netdev_ops = {
> void bnep_net_setup(struct net_device *dev)
> {
>
> - memset(dev->broadcast, 0xff, ETH_ALEN);
> + eth_broadcast_addr(dev->broadcast);
> dev->addr_len = ETH_ALEN;

Acked-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/