Re: [PATCH for-3.20-fixes] workqueue: fix hang involving racing cancel[_delayed]_work_sync()'s for PREEMPT_NONE

From: Jesper Nilsson
Date: Tue Mar 03 2015 - 02:52:13 EST


On Mon, Mar 02, 2015 at 11:21:44AM -0500, Tejun Heo wrote:
> On Mon, Mar 02, 2015 at 01:26:15PM +0100, Jesper Nilsson wrote:
> > On Mon, Feb 09, 2015 at 05:15:27PM +0100, Tejun Heo wrote:
> > > Hello,
> >
> > Hi!
> >
> > > This patch removes the possible hang by updating __cancel_work_timer()
> > > to explicitly wait for clearing of CANCELING rather than invoking
> > > flush_work() after try_to_grab_pending() fails with -ENOENT. The
> > > explicit wait uses the matching bit waitqueue for the CANCELING bit.
> > >
> > > Link: http://lkml.kernel.org/g/20150206171156.GA8942@xxxxxxxx
> > >
> > > Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> > > Reported-by: Rabin Vincent <rabin.vincent@xxxxxxxx>
> > > Cc: stable@xxxxxxxxxxxxxxx
> >
> > What's the status on this patch, it's not in 4.0-rc1 at least?
> > Is it queued for the 3.18 stable branch?
>
> Sorry about the delay. Applied to wq/for-4.0-fixes. Will push out in
> a week or so.

Thanks, that works great. Just wanted to know. :-)

> Thanks.
>
> --
> tejun

/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@xxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/