Re: [PATCH] Fixing style warnings.

[Sebastian Andrzej Siewior]

On 03/03/2015 06:19 AM, cfredric wrote:
> Signed-off-by: cfredric <chris.p.fredrickson@xxxxxxxxx>

You could use your full name here.

> ---
>  drivers/usb/core/buffer.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/core/buffer.c b/drivers/usb/core/buffer.c
> index 506b969..89f2e77 100644
> --- a/drivers/usb/core/buffer.c
> +++ b/drivers/usb/core/buffer.c
> @@ -70,7 +70,7 @@ int hcd_buffer_create(struct usb_hcd *hcd)
>  		size = pool_max[i];
>  		if (!size)
>  			continue;
> -		snprintf(name, sizeof name, "buffer-%d", size);
> +		snprintf(name, sizeof(name), "buffer-%d", size);

This looks like checkpactch warning you fixed. You could add something
to the patch description that says so.

>  		hcd->pool[i] = dma_pool_create(name, hcd->self.controller,
>  				size, size, 0);
>  		if (!hcd->pool[i]) {
> @@ -95,6 +95,7 @@ void hcd_buffer_destroy(struct usb_hcd *hcd)
>  
>  	for (i = 0; i < HCD_BUFFER_POOLS; i++) {
>  		struct dma_pool *pool = hcd->pool[i];
> +

This looks unrelated.

>  		if (pool) {
>  			dma_pool_destroy(pool);
>  			hcd->pool[i] = NULL;
> 

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/