Re: [PATCH 2/4] regulator: core: Expose init_data to of_parse_cb
From: Mark Brown
Date: Tue Mar 03 2015 - 07:50:53 EST
On Mon, Mar 02, 2015 at 08:25:38PM -0800, Bjorn Andersson wrote:
> Expose the newly created init_data to the driver's parse callback so
> that it can futher enhance it with e.g. constraints of the regulator.
Why would the driver need to do that? I guess I'll see later on in the
series but the changelog should make that clear. Drivers aren't
supposed to ever need to look at their init data, modifying the init
data from what the machine provied is usually a red flag.
> This is needed because calling regulator_register() with a of_node and
> of_match will overwrite the passed config->init_data. An alternative way
> would be to merge the parsed init_data with the driver provided one.
Put any explanation as to why the feature is needed in the changelog.
Attachment:
signature.asc
Description: Digital signature