Re: wil6210: increase cmd buffer size to avoid sscanf buffer overflow

From: Kalle Valo
Date: Tue Mar 03 2015 - 08:48:40 EST

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> cppcheck detected a buffer overflow:
> [drivers/net/wireless/ath/wil6210/debugfs.c:634]: (error) Width 8
> given in format string (no. 1) is larger than destination buffer
> 'cmd[8]', use %7s to prevent overflowing it.
> For the current %8s sscanf we require cmd to be 9 chars long
> so increase it by 1 byte to prevent the sscan overflow (rather
> than reduce the %8s specifier to %7s as cppcheck recommends).
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> Acked-by: Vladimir Kondratiev <qca_vkondrat@xxxxxxxxxxxxxxxx>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at