Re: [PATCH 3/3] mailbox: Add support for ST's Mailbox IP

[Jassi Brar]

On 3 March 2015 at 17:04, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Tuesday 03 March 2015 10:41:23 Lee Jones wrote:
>> +
>> +/*
>> + * struct sti_mbox_msg - sti mailbox message description
>> + * @dsize:             data payload size
>> + * @pdata:             message data payload
>> + */
>> +struct sti_mbox_msg {
>> +       u32             dsize;
>> +       u8              *pdata;
>> +};
>
> As mentioned in another thread, we may just want to add a 'size'
> argument to the message send function, and a default helper for
> messages with size of 32 bits.
>
Case-a) 'size' is a member of the payload structure itself
    The extra 'size' argument would only be used for sanity check.
    This driver seems so. Lee, can you not do without 'dsize'?

Case-b) 'size' is not a member of payload structure:
     b1)  payload is fixed length, that is 'size' := sizeof(struct my_payload)
            Here the size argument is redundant.

     b2)  payload length varies
            This case is highly unlikely because there would be no way
for remote to know how many bytes to read as the payload. Not to mean
we can't do without the 'size' argument.

Your opinion has huge weight, but I would like to be enlightened
before agreeing.

> I don't think it's good to fragment this further by adding
> an indirect message interface in a particular driver.
>
For example, I am reading this again and again without getting it.

Thanks
Jassi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/