Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes
From: Bjorn Andersson
Date: Tue Mar 03 2015 - 11:03:04 EST
On Tue 03 Mar 04:47 PST 2015, Mark Brown wrote:
> On Mon, Mar 02, 2015 at 08:25:37PM -0800, Bjorn Andersson wrote:
> > +- compatible:
> > + Usage: required
> > + Value type: <string>
> > + Definition: must be one of:
> > + "qcom,rpm-pm8058-regulators"
> > + "qcom,rpm-pm8901-regulators"
> > + "qcom,rpm-pm8921-regulators"
> Why do these subnodes have a compatible - do they ever appear except as
> a child of a parent of the same type of device?
The relationship with the parent node is 1:M;
in the case of 8960/8064 there is only one PMIC controlled by the RPM,
hence the dt will look like:
compatible = "qcom,rpm-apq8960";
compatible = "qcom,rpm-pm8921-regulators";
But for 8660, and later for e.g. 8974 we have something like:
compatible = "qcom,rpm-msm8660";
compatible = "qcom,rpm-pm8058-regulators";
vdd_xxx-supply = <&pm8058_s4>;
compatible = "qcom,rpm-pm8901-regulators";
I intended to match these by name, having one rpm-regulator device
instance and using desc->regulators_node to match regulators in the
right node - with of_node being the rpm node.
But this doesn't really map to reality, as supplies are a property of
pm8058 and pm8901 and not of the rpm. I ended up writing some custom
device registering code to instantiate the right number of regulator
children and give each of them the right of_node etc.
But as several other of-based platforms have a compatible in their
regulators node I consider that a viable and cleaner solution.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/