Re: [RFT PATCH v3 2/2] compal-laptop: Check return value of power_supply_register

From: Darren Hart
Date: Tue Mar 03 2015 - 11:43:21 EST

On Fri, Feb 20, 2015 at 02:13:35PM +0100, Krzysztof Kozlowski wrote:
> The return value of power_supply_register() call was not checked and
> even on error probe() function returned 0. If registering failed then
> during unbind the driver tried to unregister power supply which was not
> actually registered.
> This could lead to memory corruption because power_supply_unregister()
> unconditionally cleans up given power supply.
> Fix this by checking return status of power_supply_register() call. In
> case of failure, clean up sysfs entries and fail the probe.
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> Fixes: 9be0fcb5ed46 ("compal-laptop: add JHL90, battery & hwmon interface")
> Cc: <stable@xxxxxxxxxxxxxxx>

Acked-by: Darren Hart <dvhart@xxxxxxxxxxxxxxx>

Darren Hart
Intel Open Source Technology Center
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at