Re: [PATCH 4/4] thinkpad_acpi: Add support for more adaptive kbd buttons

[Darren Hart]

On Mon, Mar 02, 2015 at 02:17:01PM -0300, Henrique de Moraes Holschuh wrote:
> On Mon, Mar 2, 2015, at 10:45, Bastien Nocera wrote:
> > This commit adds new elements to the ThinkPad keymaps, and
> > will send key events for keys for which an input.h declaration
> > exists.
> > 
> > Signed-off-by: Bastien Nocera <hadess@xxxxxxxxxx>
> 
> Reviewed-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>
> Acked-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>

As I understand it, and how I interpret these tags, Reviewed-by is a superset of
Acked-by. Acked implies acceptance of the general idea, Reviewed implies a
careful code review. No need for both.

I'm queueing these for testing in the pdx86 tree because we've been discussing
that approach. However, I've asked Henrique to let me know how he prefers to
handle this driver.

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/