Re: [PATCH 1/2] x86/regsets: change xstateregs_get/set to use ->xsave.i387 rather than ->fxsave

From: Rik van Riel
Date: Tue Mar 03 2015 - 14:24:03 EST


On 03/02/2015 01:32 PM, Oleg Nesterov wrote:
> Cosmetic. xstateregs_get() and xstateregs_set() abuse ->fxsave to access
> xsave->i387.sw_reserved. This is correct, ->fxsave and xsave->i387 share
> the same memory, but imho this looks confusing.
>
> And we can make this code more readable if we add "struct xsave_struct *"
> local.
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Reviewed-by: Rik van Riel <riel@xxxxxxxxxx>

--
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/