Re: [PATCH net-next] openvswitch: Fix serialization of non-masked set actions.

From: David Miller
Date: Tue Mar 03 2015 - 15:56:48 EST


From: Joe Stringer <joestringer@xxxxxxxxxx>
Date: Tue, 3 Mar 2015 12:38:54 -0800

> On 3 March 2015 at 11:39, David Miller <davem@xxxxxxxxxxxxx> wrote:
>> From: Joe Stringer <joestringer@xxxxxxxxxx>
>> Date: Mon, 2 Mar 2015 18:49:56 -0800
>>
>>> Set actions consist of a regular OVS_KEY_ATTR_* attribute nested inside
>>> of a OVS_ACTION_ATTR_SET action attribute. When converting masked actions
>>> back to regular set actions, the inner attribute length was not changed,
>>> ie, double the length being serialized. This patch fixes the bug.
>>>
>>> Fixes: 83d2b9b ("net: openvswitch: Support masked set actions.")
>>> Signed-off-by: Joe Stringer <joestringer@xxxxxxxxxx>
>>> ---
>>> This fix needs to be applied to net as well; it applies cleanly.
>>
>> This is backwards, don't do this. Just say that 'net' needs the fix
>> and submit it targetting that tree only. Things in 'net' propagate
>> into 'net-next' automatically as I do merges over time, but the
>> opposite is not true.
>
> OK, I'll resend.

If you actually checked the 'net' tree, I applied your patch and even sent
it off to Linus via a pull request 15 minutes ago.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/