Re: [PATCH 2/2] x86/fpu: factor out memset(xstate, 0) in fpu_finit() paths
From: Rik van Riel
Date: Tue Mar 03 2015 - 17:01:37 EST
On 03/02/2015 01:32 PM, Oleg Nesterov wrote:
> fx_finit() has 2 users but only fpu_finit() needs to nullify xstate,
> alloc_bootmem_align() in setup_init_fpu_buf() returns zero-filled
> memory.
>
> And note that both memset()'s look confusing. Yes, offsetof() is 0
> for ->fxsave or ->fsave, but it would be more clean to turn them into
> a single memset() which nullifies fpu->state.
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
Acked-by: Rik van Riel <riel@xxxxxxxxxx>
--
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/