Re: [PATCH] video: ARM CLCD: Added support for FBIO_WAITFORVSYNC

[Arun Ramamurthy]

On 15-03-02 03:27 PM, Rob Herring wrote:
> On Mon, Mar 2, 2015 at 10:00 AM, Pawel Moll <pawel.moll@xxxxxxx> wrote:
> > On Wed, 2015-02-25 at 21:01 +0000, Arun Ramamurthy wrote:
> > > Added ioctl and interrupt handler functions to support FBIO_WAITFORVSYNC
> > > Also corrected documentation to make interrupts and interrupt-names
> > > optional as they are not required properties.
> >
> > You may not be aware of this fact, but its the "documentation" what
> > defines what properties are required...
>
> Except when docs are wrong. Then dts files win.
>
> > > Reviewed-by: Ray Jui <rjui@xxxxxxxxxxxx>
> > > Reviewed-by: Scott Branden <sbranden@xxxxxxxxxxxx>
> > > Signed-off-by: Arun Ramamurthy <arun.ramamurthy@xxxxxxxxxxxx>0
> > > ---
> > >   .../devicetree/bindings/video/arm,pl11x.txt        | 11 +--
> > >   drivers/video/fbdev/amba-clcd.c                    | 82 ++++++++++++++++++++++
> > >   include/linux/amba/clcd.h                          |  4 ++
> > >   3 files changed, 89 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/video/arm,pl11x.txt b/Documentation/devicetree/bindings/video/arm,pl11x.txt
> > > index 2262cdb..7d19024 100644
> > > --- a/Documentation/devicetree/bindings/video/arm,pl11x.txt
> > > +++ b/Documentation/devicetree/bindings/video/arm,pl11x.txt
> > > @@ -10,14 +10,6 @@ Required properties:
> > >
> > >   - reg: base address and size of the control registers block
> > >
> > > -- interrupt-names: either the single entry "combined" representing a
> > > -     combined interrupt output (CLCDINTR), or the four entries
> > > -     "mbe", "vcomp", "lnbu", "fuf" representing the individual
> > > -     CLCDMBEINTR, CLCDVCOMPINTR, CLCDLNBUINTR, CLCDFUFINTR interrupts
> > > -
> > > -- interrupts: contains an interrupt specifier for each entry in
> > > -     interrupt-names
> > > -
> > >   - clock-names: should contain "clcdclk" and "apb_pclk"
> > >
> > >   - clocks: contains phandle and clock specifier pairs for the entries
> >
> > So no, you can't do that.
>
> You can't do the other way around (making optional ones required), but
> I think this is okay if the h/w interrupt lines are not physically
> connected. However, if it is simply because the driver doesn't use
> them, then I agree this should not be changed.
Agreed, I will undo this change in V2
> Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/