Re: node-hotplug: is memset 0 safe in try_offline_node()?

[Xishi Qiu]

On 2015/3/4 10:22, Xishi Qiu wrote:

> On 2015/3/3 18:20, Gu Zheng wrote:
> 
>> Hi Xishi,
>> On 03/03/2015 11:30 AM, Xishi Qiu wrote:
>>
>>> When hot-remove a numa node, we will clear pgdat,
>>> but is memset 0 safe in try_offline_node()?
>>
>> It is not safe here. In fact, this is a temporary solution here.
>> As you know, pgdat is accessed lock-less now, so protection
>> mechanism (RCUï) is needed to make it completely safe here,
>> but it seems a bit over-kill.
>>

Hi Gu,

Can we just remove "memset(pgdat, 0, sizeof(*pgdat));" ?
I find this will be fine in the stress test except the warning 
when hot-add memory.

Thanks,
Xishi Qiu

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/