Re: [PATCH 1/5] can: kvaser_usb: Avoid double free on URB submission failures

From: Marc Kleine-Budde
Date: Wed Mar 04 2015 - 04:19:00 EST

On 02/26/2015 04:20 PM, Ahmed S. Darwish wrote:
> From: Ahmed S. Darwish <ahmed.darwish@xxxxxxxxx>
> Upon a URB submission failure, the driver calls usb_free_urb()
> but then manually frees the URB buffer by itself. Meanwhile
> usb_free_urb() has alredy freed out that transfer buffer since
> we're the only code path holding a reference to this URB.
> Remove two of such invalid manual free().
> Signed-off-by: Ahmed S. Darwish <ahmed.darwish@xxxxxxxxx>

Applied 1+2 and added stable on Cc. Can you please shuffle the remaining
patches, so that patch 5 comes first, then 4 and 3 as the last patch. As
5 is a bugfix it should go into stable, while 3 isn't.

You can base your series on the can/testing branch.


Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | |

Attachment: signature.asc
Description: OpenPGP digital signature