Re: [PATCH v3] spi: qup: Add DMA capabilities
From: Stanimir Varbanov
Date: Wed Mar 04 2015 - 04:37:34 EST
On 03/04/2015 10:38 AM, Ivan T. Ivanov wrote:
>
> Hi Stan,
>
> It looks good now, except it doesn't apply and two small issues below:
>
<snip>
>
>> +
>> + /* set DMA parameters */
>> + rx_conf->direction = DMA_DEV_TO_MEM;
>> + rx_conf->device_fc = 1;
>
> Strictly speeching this is a bool not int.
sure will correct.
>>
>> + ret = spi_qup_init_dma(master, res->start);
>> + if (ret == -EPROBE_DEFER)
>> + goto error;
>> + else if (!ret)
>> + master->can_dma = spi_qup_can_dma;
>> +
>> /* set v1 flag if device is version 1 */
>> if (of_device_is_compatible(dev->of_node, "qcom,spi-qup-v1.1.1"))
>> controller->qup_v1 = 1;
>
> It is not visible from this patch, but in case of error reseting
> SPI controller (QUP_STATE_RESET), exit error path should be
> 'error_dma' and not 'error' label.
my fault, will correct.
regards,
Stan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/