Re: [PATCH RFT v2] x86: move cacheinfo sysfs to generic cacheinfo infrastructure

From: Sudeep Holla
Date: Wed Mar 04 2015 - 06:35:28 EST




On 04/03/15 11:27, Borislav Petkov wrote:
On Wed, Mar 04, 2015 at 11:15:49AM +0000, Sudeep Holla wrote:
I can do that, but wouldn't that add confusion as this commit is not
changing that behaviour. It's already changed in v4.0-rc1

Nah, this would add a reference to the fact that the cpumask format is
not really a stable thing and thus cannot be considered a userpsace
regression. And having this info is important IMO in case someone is
wondering in the future.


Thanks for clarifying, will add that info. Now I think it completely
makes sense especially since this commit will be the first target when
user-space first notice this cpumask format change.

In general, having more and even redundant info in the commit messages
is much better than having less info. I can't count the times I've been
staring at a one-liner commit message and trying to rhyme up what was
the purpose of doing it this way.

So more is more, in this case. :-)


Agreed :)

--
Regards,
Sudeep

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/