Re: [PATCH RFT] phy: exynos-mipi-video: Use spin_lock to protct state->regmap rmw operations

[Kishon Vijay Abraham I]

Hi,

On Friday 27 February 2015 06:57 PM, Sylwester Nawrocki wrote:
> On 27/02/15 04:50, Axel Lin wrote:
> > he state->regmap is initialized by devm_regmap_init_mmio().
> > So it's fine to use spin_lock rather than mutex to protct state->regmap rmw
> > operations.
> >
> > Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
> > ---
> > Hi Sylwester,
> > I don't have this hardware handy, so can you test if this patch works.
> > This patch is on top of my previous patch (phy: exynos-mipi-video: Fixup
> > the test for state->regmap)
>
> Thanks for the patch, it looks good to me. I somehow missed the syscon
> already uses a spinlock for regmap protection.
>
> v4.0-rc1 seems devastated as far as exynos4 is concerned, it may take
> some time until I get around and fix all the issues so I tested your
> patch on v3.19. It all works well as expected.
>
> Acked-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
> Tested-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>

This patch doesn't apply on 4.0-rc1. Can to refresh it to mainline
latest?

Cheers
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/