Re: [PATCH] Remove redhat'ism from ftrace selftests.

From: Namhyung Kim
Date: Wed Mar 04 2015 - 07:45:43 EST


Hello,

On Wed, Mar 04, 2015 at 09:47:47PM +1100, Michael Ellerman wrote:
> On Tue, 2015-03-03 at 17:05 -0700, Shuah Khan wrote:
> > On 02/27/2015 08:16 PM, Namhyung Kim wrote:
> > > On Tue, Feb 24, 2015 at 01:24:59PM -0500, Dave Jones wrote:
> > >> On Tue, Feb 24, 2015 at 11:22:58AM -0700, Shuah Khan wrote:
> > >> > On 02/24/2015 11:18 AM, Steven Rostedt wrote:
> > >> > >
> > >> > > Shuah,
> > >> > >
> > >> > > Can you take this in your tree?
> > >> >
> > >> > Yes I can do that. This must be the original patch email:
> > >> > https://lkml.org/lkml/2015/2/24/435
> > >
> > > Please see below links:
> > >
> > > https://lkml.org/lkml/2014/12/10/52
> > > https://lkml.org/lkml/2014/12/22/556
> > >
> > > I think we can get rid of the (u)sleeps entirely since 'cat trace'
> > > itself should trigger scheduler events.
> >
> > Steve/Dave,
> >
> > Still good to take it through. The discussion in the threads
> > Namhyung Kim pointed to seem to be inconclusive.
> >
> > The only difference between the original patch
> > https://lkml.org/lkml/2014/12/9/780
> > and
> > https://lkml.org/lkml/2015/2/24/435
> >
> > is sleep duration change. I can take through my tree
> > https://lkml.org/lkml/2015/2/24/435
> >
> > just confirming.
>
> No, the resoultion was that busybox doesn't support fractional sleeps and so
> using them is not a solution.
>
> I thought /bin/true would work, but never got around to testing it. The other
> option was to use (echo "forked"):
>
> https://lkml.org/lkml/2014/12/23/447

I think that there's no need to even call true or echo..