Re: [PATCH v3 3/9] watchdog: at91rm9200: use the system timer syscon

From: Alexandre Belloni
Date: Wed Mar 04 2015 - 10:08:23 EST


On 04/03/2015 at 06:51:51 -0800, Guenter Roeck wrote :
> >@@ -267,7 +276,7 @@ static struct platform_driver at91wdt_driver = {
> > .suspend = at91wdt_suspend,
> > .resume = at91wdt_resume,
> > .driver = {
> >- .name = "at91_wdt",
> >+ .name = "atmel_st_watchdog",
>
> If you change the driver name you also need to change the MODULE_ALIAS
> a few lines down.
>
> But why change it in the first place ? Maybe that was discussed somewhere,
> but not here where it belongs, and not in patch 0/9 either.
>

That's because it conflicts with drivers/watchdog/at91sam9_wdt.c

I'm not sure that is relevant anymore as they will only be probed using
DT now.


--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/