Re: [PATCH 05/16] arch: x86: kernel: Make internal functions static in cpu/intel_cacheinfo.c

[Borislav Petkov]

On Wed, Mar 04, 2015 at 07:02:07PM +0530, Darshana Padmadas wrote:
> cpu/intel_cacheinfo.c defines two functions amd_get_l3_disable_slot
> and amd_set_l3_disable_slot. No other file uses these functions.
> So make these static.
> 
> This eliminates the following warnings:
> 
> arch/x86/kernel/cpu/intel_cacheinfo.c:349:5: warning: no previous prototype for âamd_get_l3_disable_slotâ [-Wmissing-prototypes]
> arch/x86/kernel/cpu/intel_cacheinfo.c:427:5: warning: no previous prototype for âamd_set_l3_disable_slotâ [-Wmissing-prototypes]

Please correct your commit message - this patch is making functions
static and not fixing -Wmissing-prototypes warnings. Also, go through
the rest of the patchset as I see other cases of this too.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/