Re: [PATCH v5 8/9] rtc: st: add new driver for ST's LPC RTC

[Paul Bolle]

Lee Jones schreef op wo 04-03-2015 om 18:06 [+0000]:
> --- /dev/null
> +++ b/drivers/rtc/rtc-st-lpc.c
> @@ -0,0 +1,354 @@
> +/*
> + * rtc-st-lpc.c - ST's LPC RTC, powered by the Low Power Timer
> + *
> + * Copyright (C) 2014 STMicroelectronics Limited
> + *
> + * Author: David Paris <david.paris@xxxxxx> for STMicroelectronics
> + *         Lee Jones <lee.jones@xxxxxxxxxx> for STMicroelectronics
> + *
> + * Based on the original driver written by Stuart Menefy.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public Licence
> + * as published by the Free Software Foundation; either version
> + * 2 of the Licence, or (at your option) any later version.
> + */

This states the license is GPL v2 or later.

> +MODULE_LICENSE("GPLv2");

This will taint the kernel at module load, won't it? You probably meant
"GPL v2", but only
    MODULE_LICENSE("GPL");

correctly matches the license in the comment at the top of this file. 

(I assume I missed all this when looking at the v4 series.)


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/