Re: [PATCH] ihex: restore missing default in switch statement

[Andrew Morton]

On Wed,  4 Mar 2015 22:24:10 +0800 Nicolas Iooss <nicolas.iooss_linux@xxxxxxx> wrote:

> Commit 2473238eac95 ("ihex: add support for CS:IP/EIP records") removes
> the "default:" statement in the switch block, making the "return
> usage();" line dead code and ihex2fw silently ignoring unknown options.
> Restore this statement.
> 
> This bug was found by building with HOSTCC=clang and adding
> -Wunreachable-code-return to HOSTCFLAGS.
> 
> ...
>
> --- a/firmware/ihex2fw.c
> +++ b/firmware/ihex2fw.c
> @@ -86,6 +86,7 @@ int main(int argc, char **argv)
>  		case 'j':
>  			include_jump = 1;
>  			break;
> +		default:
>  			return usage();
>  		}
>  	}

whee.  So if there's userspace out there which is passing bad options
to ihex2fw, this fix will break it.

Oh well, I expect we'll survive.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/