Re: [PATCH v2 9/9] change the relocations behavior for kaslr on x86_64

From: Yinghai Lu
Date: Wed Mar 04 2015 - 18:16:58 EST


On Mon, Mar 2, 2015 at 6:58 AM, Baoquan He <bhe@xxxxxxxxxx> wrote:

> @@ -455,17 +455,16 @@ unsigned char *choose_kernel_location(struct boot_params *params,
> output_size);

you forgot to change

/* Record the various known unsafe memory ranges. */
mem_avoid_init((unsigned long)input, input_size,
(unsigned long)output, init_size);

to

/* Record the various known unsafe memory ranges. */
mem_avoid_init((unsigned long)input, input_size,
(unsigned long)*output, init_size);

>
> /* Walk e820 and find a random address. */
> - random = find_random_addr(choice, output_size);
> - if (!random) {
> + random = find_random_phy_addr((unsigned long)*output, output_size);
> + if (!random)
> debug_putstr("KASLR could not find suitable E820 region...\n");
> - goto out;
> - }
> + else
> + *output = (unsigned char*)random;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/