Re: [PATCH] ftracetest: Don't use non-POSIX exit -1
From: Masami Hiramatsu
Date: Wed Mar 04 2015 - 21:40:43 EST
(2015/03/05 11:04), Michael Ellerman wrote:
> POSIX says that exit takes an unsigned integer between 0 and 255.
>
> Convert exit -1 to exit 255.
Good catch :)
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
Thanks!
>
> Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> ---
> tools/testing/selftests/ftrace/test.d/00basic/basic4.tc | 2 +-
> tools/testing/selftests/ftrace/test.d/event/event-enable.tc | 2 +-
> tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc | 2 +-
> tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc | 2 +-
> tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc | 2 +-
> tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc | 2 +-
> tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/00basic/basic4.tc b/tools/testing/selftests/ftrace/test.d/00basic/basic4.tc
> index fd9c49a13612..f6b9fc323ee0 100644
> --- a/tools/testing/selftests/ftrace/test.d/00basic/basic4.tc
> +++ b/tools/testing/selftests/ftrace/test.d/00basic/basic4.tc
> @@ -2,4 +2,4 @@
> # description: Basic event tracing check
> test -f available_events -a -f set_event -a -d events
> # check scheduler events are available
> -grep -q sched available_events && exit 0 || exit -1
> \ No newline at end of file
> +grep -q sched available_events && exit 0 || exit 255
> \ No newline at end of file
> diff --git a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> index 668616d9bb03..59a352408284 100644
> --- a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> +++ b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> @@ -9,7 +9,7 @@ do_reset() {
> fail() { #msg
> do_reset
> echo $1
> - exit -1
> + exit 255
> }
>
> if [ ! -f set_event -o ! -d events/sched ]; then
> diff --git a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
> index 655c415b6e7f..1e4dbf06d690 100644
> --- a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
> +++ b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
> @@ -9,7 +9,7 @@ do_reset() {
> fail() { #msg
> do_reset
> echo $1
> - exit -1
> + exit 255
> }
>
> if [ ! -f set_event -o ! -d events/sched ]; then
> diff --git a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> index 480845774007..6b6a12cba387 100644
> --- a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> +++ b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> @@ -9,7 +9,7 @@ do_reset() {
> fail() { #msg
> do_reset
> echo $1
> - exit -1
> + exit 255
> }
>
> if [ ! -f available_events -o ! -f set_event -o ! -d events ]; then
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc b/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc
> index c15e018e0220..7320344072ec 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc
> @@ -25,7 +25,7 @@ do_reset() {
> fail() { # msg
> do_reset
> echo $1
> - exit -1
> + exit 255
> }
>
> disable_tracing
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc b/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc
> index 6af5f6360b18..9f63b8081f7c 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc
> @@ -17,7 +17,7 @@ do_reset() {
> fail() { # msg
> do_reset
> echo $1
> - exit -1
> + exit 255
> }
>
> disable_tracing
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc
> index 2e719cb1fc4d..e01ea0a9764e 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc
> @@ -31,7 +31,7 @@ fail() { # mesg
> reset_tracer
> echo > set_ftrace_filter
> echo $1
> - exit -1
> + exit 255
> }
>
> echo "Testing function tracer with profiler:"
>
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@xxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/