Re: [PATCH 2/3] crypto: caam_rng: fix rng_unmap_ctx's DMA_UNMAP size problem

[yjin]

On 2015å03æ05æ 02:36, Kim Phillips wrote:
> On Wed, 4 Mar 2015 13:33:22 +0800
> yjin <yanjiang.jin@xxxxxxxxxxxxx> wrote:
>
> > On 2015å03æ04æ 03:31, Kim Phillips wrote:
> > > On Tue, 3 Mar 2015 14:50:52 +0800
> > > <yanjiang.jin@xxxxxxxxxxxxx> wrote:
> > >
> > > > -		dma_unmap_single(jrdev, ctx->sh_desc_dma, DESC_RNG_LEN,
> > > > -				 DMA_TO_DEVICE);
> > > > +		dma_unmap_single(jrdev, ctx->sh_desc_dma,
> > > > +				desc_bytes(ctx->sh_desc), DMA_TO_DEVICE);
> > > alignment: the 'd' in desc_bytes should fall directly under the 'j'
> > > in jrdev.
> > >
> > > Also, DESC_RNG_LEN should be corrected to (4 * CAAM_CMD_SZ).
> > Hi Kim,
> >
> > I can't find the obvious limitation for the RNG descriptor length in
> > Freescale documents, could you point out it?
> ?  rng_create_sh_desc() creates a fixed descriptor of exactly 4
> command-lengths.

Hi Kim,

Do you mean that the code itself limits the descriptor length? Not a 
hardware limitation.
If so, I prefer to dma_unmap with desc_bytes(ctx->sh_desc) as my 
previous patch, and correct DESC_RNG_LEN to (4 * CAAM_CMD_SZ).

Thanks!
Yanjiang

> Kim

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/