Re: [PATCH v2] ARM64: Add new Xilinx ZynqMP SoC

[Thomas Petazzoni]

Dear Michal Simek,

On Thu,  5 Mar 2015 14:53:34 +0100, Michal Simek wrote:

> +	pmu {
> +		compatible = "arm,armv8-pmuv3";
> +		interrupts = <0 143 4>,
> +			     <0 144 4>,
> +			     <0 145 4>,
> +			     <0 146 4>;

Any reason not to use

#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/interrupt-controller/irq.h>

in order to write the more descriptive:

		interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>,
			     <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>,
			     <GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>,
			     <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>;

And ditto for all other interrupts properties?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/