Re: [PATCH] Remove redhat'ism from ftrace selftests.

From: Dave Jones
Date: Thu Mar 05 2015 - 10:17:26 EST


On Thu, Mar 05, 2015 at 08:14:42AM -0700, Shuah Khan wrote:
> On 03/04/2015 06:18 PM, Michael Ellerman wrote:
> > On Wed, 2015-03-04 at 21:44 +0900, Namhyung Kim wrote:
> >>
> >> I think that there's no need to even call true or echo..
> >>
> >> From 0549544e8e982df6478f11e2b4fe419f94c22434 Mon Sep 17 00:00:00 2001
> >> From: Namhyung Kim <namhyung@xxxxxxxxxx>
> >> Date: Wed, 4 Mar 2015 21:26:38 +0900
> >> Subject: [PATCH] ftracetest: Do not use usleep
> >>
> >> The usleep is only provided on distros from Redhat so running ftracetest
> >> on other distro resulted in failures due to the missing usleep.
> >>
> >> The reason of using [u]sleep in the test was to generate (scheduler)
> >> events. But as we use 'cat trace | grep | wc -l' to read the events,
> >> the command themselves already generate some events before reading the
> >> trace file so no need to call [u]sleep explicitly.
> >>
> >> Reported-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> >> Reported-by: Dave Jones <davej@xxxxxxxxxxxxxxxxx>
> >> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> >
> > Thanks, this is working for me.
> >
> > Tested-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> >
>
> Steve,
>
> Do you want to make a call on which one you want me to take it
> through between these two patches - one from Dave and the other
> from Namhyung Kim.
>
> Please send me the patch I have to pull in. Namhyung Kim's patch
> isn't in the format I can apply and I don't have Dave's patch in
> my inbox.

Removing it entirely sounds like a much better choice, so I'd
wait for Namhyung to resend.

Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/