Re: [PATCH 2/7] context_tracking: Rename context symbols to prepare for transition state

[Rik van Riel]

On 03/04/2015 09:14 PM, Frederic Weisbecker wrote:
> Current context tracking symbols are designed to express living state.
> As such they are prefixed with "IN_": IN_USER, IN_KERNEL.
> 
> Now we are going to use these symbols to also express state transitions
> such as context_tracking_enter(IN_USER) or context_tracking_exit(IN_USER).
> But while the "IN_" prefix works well to express entering a context, it's
> confusing to depict a context exit: context_tracking_exit(IN_USER)
> could mean two things:
> 	1) We are exiting the current context to enter user context.
> 	2) We are exiting the user context
> We want 2) but the reviewer may be confused and understand 1)
> 
> So lets disambiguate these symbols and rename them to CONTEXT_USER and
> CONTEXT_KERNEL.
> 
> Cc: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
> Cc: Will deacon <will.deacon@xxxxxxx>
> Cc: Marcelo Tosatti <mtosatti@xxxxxxxxxx>
> Cc: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> Cc: Luiz Capitulino <lcapitulino@xxxxxxxxxx>
> Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>

Acked-by: Rik van Riel <riel@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/