Re: [PATCH 2/2 v2] kernel: irq: rename irq_set_default_host to irq_domain_set_default()

From: Linus Walleij
Date: Fri Mar 06 2015 - 05:20:52 EST


On Mon, Feb 16, 2015 at 1:09 PM, Benjamin Herrenschmidt
<benh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, 2015-02-16 at 10:53 +0100, Peter Zijlstra wrote:
>> On Fri, Feb 13, 2015 at 08:02:17AM +0800, Linus Walleij wrote:
>> > This function does not conform to the irq_domain* namespace and
>> > makes it a disturbing artifact dating back to a time when irq
>> > domains were referred to as "hosts". Rename it.
>
> My little coat of paint on that shed...
>
> While I agree with the need to rename it, do we really need to adhere to
> strict namespaces like that ? It would be a lot nicer to call it
> irq_set_default_domain() :-)

Since all other functions in <linux/irqdomain.h> begin with the
irq_domain* prefix that seriously disturbs my OCD ... ;)

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/