Re: [PATCH] mfd: kempld-core: Fix callback return value check

From: Lee Jones
Date: Fri Mar 06 2015 - 07:04:27 EST


On Thu, 26 Feb 2015, Ameya Palande wrote:

> On success, callback function returns 0. So invert the if condition
> check so that we can break out of loop.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Ameya Palande <2ameya@xxxxxxxxx>
> ---
> drivers/mfd/kempld-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c
> index f38ec42..5615522 100644
> --- a/drivers/mfd/kempld-core.c
> +++ b/drivers/mfd/kempld-core.c
> @@ -739,7 +739,7 @@ static int __init kempld_init(void)
> for (id = kempld_dmi_table;
> id->matches[0].slot != DMI_NONE; id++)
> if (strstr(id->ident, force_device_id))
> - if (id->callback && id->callback(id))
> + if (id->callback && !id->callback(id))
> break;
> if (id->matches[0].slot == DMI_NONE)
> return -ENODEV;

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/