Re: [ibm-acpi-devel] [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

From: Darren Hart
Date: Fri Mar 06 2015 - 13:10:02 EST

On Tue, Mar 03, 2015 at 03:39:54PM -0300, Henrique de Moraes Holschuh wrote:
> On Tue, Mar 3, 2015, at 13:52, Darren Hart wrote:
> > Henrique, I believe I may have overstepped with thinkpad-acpi and dealt
> > with it like the other drivers in platform/drivers/x86, when instead I should
> > have been leaving it to you. My apologies, it was not intentional.
> No harm done! And I did appreciate the extra help :-)
> > Do you typically send pull-requests for the thinkpad-acpi driver directly to Linus?
> thinkpad-acpi is part of the platform-x86 subsystem, so IMHO it should
> continue to be merged through your tree if you are okay with that.
> I'd really appreciate if the typical patch approval flux would go
> through me first. However, I certainly don't mind if you merge patches
> directly should I be unresponsible for some reason, or when they are
> part of the usual tree-wide spot fixes for some pattern/anti-pattern,
> etc.
> > I would be more than happy to basically ignore anything to thinkpad-acpi until
> > after you have provided a review. I can also roll up pull requests from
> > you if you prefer to integrate into the platform-drivers-x86 tree as the path to
> > Linus.
> Well, if it is fine with you, I'd suggest we continue with the process
> used in this patchset, where I will reply to patches in this ML with a
> reviewed-by or acked-by before you merge them.
> If you want to change that at some point, just drop me a note and I will
> start pushing patches to you either through this ML or through signed
> pull requests, whichever you prefer.

Great. Things are documented correctly in MAINTAINERS then and we can continue
as before, only I will be more diligent making sure you are Cc'd and have
responded to any thinkpad-acpi.c changes. I assume two weeks is sufficient, but
may nag you after a week.


Darren Hart
Intel Open Source Technology Center
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at